feat(cdk-mintd): move remote signatory config into its own section#2141
Open
prusnak wants to merge 3 commits into
Open
feat(cdk-mintd): move remote signatory config into its own section#2141prusnak wants to merge 3 commits into
prusnak wants to merge 3 commits into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2141 +/- ##
==========================================
+ Coverage 71.63% 71.65% +0.02%
==========================================
Files 356 357 +1
Lines 74794 74876 +82
==========================================
+ Hits 53576 53655 +79
- Misses 21218 21221 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
prusnak
force-pushed
the
cdk-mintd-explicit-insecure-signatory
branch
from
4b27fcd to
b75faac
Compare
cdk-bot
reviewed
Jun 27, 2026
cdk-bot
left a comment
cdk-bot
left a comment
Collaborator
There was a problem hiding this comment.
Verified findings approved for disclosure:
- Empty [signatory] section in example config enables remote signatory and breaks startup (medium) - Operators following the documented copy-and-edit example config path can no longer start a mint with a local seed/mnemonic; the mint enters remote-signatory mode and bails during startup.
prusnak
force-pushed
the
cdk-mintd-explicit-insecure-signatory
branch
from
b75faac to
ddd8fcc
Compare
cdk-bot
reviewed
Jun 28, 2026
cdk-bot
left a comment
cdk-bot
left a comment
Collaborator
There was a problem hiding this comment.
Verified findings approved for disclosure:
- SignatoryRpcClient URL construction breaks IPv6 addresses (low) - IPv6 signatory addresses configured as ordinary address literals fail URL parsing, regressing remote signatory connectivity for IPv6 deployments.
Unanchored locations included in summary:- crates/cdk-signatory/src/proto/client.rs:54
- Deprecated signatory config keys are silently ignored, allowing fallback to local signing (low) - Upgraded deployments with old signatory config keys and a local seed/mnemonic can silently stop using the remote signatory and fall back to local signing.
Unanchored locations included in summary:- crates/cdk-mintd/src/config.rs:47
Replace the old [info] signatory URL/certs fields with a dedicated [signatory] section using addr, port, tls_dir, and allow_insecure. Require an explicit allow_insecure=true when connecting to a remote signatory without TLS, and update the signatory client constructor to build its endpoint from addr/port. Update env vars, example config, and integration fixtures to use the new shape.
prusnak
force-pushed
the
cdk-mintd-explicit-insecure-signatory
branch
from
ddd8fcc to
e355963
Compare
…dress but keep compatibility with old shorter name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the old [info] signatory URL/certs fields with a dedicated [signatory] section using addr, port, tls_dir, and allow_insecure - copying the config layout for mint_management_rpc / grpc_processor.
Require an explicit allow_insecure=true when connecting to a remote signatory without TLS, and update the signatory client constructor to build its endpoint from addr/port. Update env vars, example config, and integration fixtures to use the new shape.
Add README.md to cdk-signatory.